Adding new test and docs for issue #416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
reviewed
Nov 25, 2025
| Args: | ||
| space: Configuration space | ||
| vector: Parameter vector |
Contributor
There was a problem hiding this comment.
Suggested change
| vector: Parameter vector | |
| vector: The hyperparameter vector to check. | |
| Raises an Exception if the vector is not valid. | ||
| Args: | ||
| space: Configuration space |
Contributor
There was a problem hiding this comment.
Suggested change
| space: Configuration space | |
| space: The configuration space to check the parameter vector against. | |
| Args: | ||
| space: Configuration space | ||
| vector: Parameter vector | ||
| allow_inactive_with_values: If True, inactive parameters are allowed to have values in the vector. |
Contributor
There was a problem hiding this comment.
Suggested change
| allow_inactive_with_values: If True, inactive parameters are allowed to have values in the vector. | |
| allow_inactive_with_values: If True, inactive hyperparameters are allowed to have values in the vector. | |
| vector: np.ndarray, | ||
| allow_inactive_with_values: bool = False, | ||
| ) -> None: | ||
| """Checks whether a given parameter vector is valid according to the conditionals and forbiddens. |
Contributor
There was a problem hiding this comment.
Suggested change
| """Checks whether a given parameter vector is valid according to the conditionals and forbiddens. | |
| """Check if a given hyperparameter vector is valid according to the conditionals and forbiddens. | |
|
|
||
| # Parameter A has no conditions; check if the configuration fails if a > 10 | ||
| with pytest.raises(IllegalValueError): | ||
| sample["a"] = 101 |
Contributor
There was a problem hiding this comment.
Does this actually trigger a call to check configuration or does this fail somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #399 ;
Added test for the raised issue, which passes. Which parts of the documentation should be clarified to reflect that this is indeed tested by ConfigSpace?